[webkit-reviews] review granted: [Bug 203041] [LFC][IFC] Fix various vertical alignment issues. : [Attachment 381083] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 203041: [LFC][IFC] Fix various vertical alignment issues.
https://bugs.webkit.org/show_bug.cgi?id=203041

Attachment 381083: Patch

https://bugs.webkit.org/attachment.cgi?id=381083&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 381083
  --> https://bugs.webkit.org/attachment.cgi?id=381083
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381083&action=review

> Source/WebCore/layout/inlineformatting/InlineLine.cpp:190
> +		   // The inline-block's baseline offset is relative to its
content box. Let's convert it relative to the margin box.
> +		   //	inline-block
> +		   //		   \
> +		   //		_______________ <- margin box
> +		   //	       |
> +		   //	       |  ____________	<- border box
> +		   //	       | |
> +		   //	       | |  _________  <- content box
> +		   //	       | | |   ^
> +		   //	       | | |   |  <- baseline offset
> +		   //	       | | |   |
> +		   //	  text | | |   v text
> +		   //	  -----|-|-|---------- <- baseline
> +		   //

Nice art.