[webkit-reviews] review denied: [Bug 203020] WKWebsiteDataStoreStatisticsResetToConsistentState() should call store.setUseITPDatabase(false) : [Attachment 381093] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Katherine_cheney at apple.com's request
for review:
Bug 203020: WKWebsiteDataStoreStatisticsResetToConsistentState() should call
store.setUseITPDatabase(false)
https://bugs.webkit.org/show_bug.cgi?id=203020

Attachment 381093: Patch

https://bugs.webkit.org/attachment.cgi?id=381093&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 381093
  --> https://bugs.webkit.org/attachment.cgi?id=381093
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381093&action=review

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:1793
> +void TestRunner::setUseITPDatabase(bool value, JSValueRef completionHandler)

This does not need a completion handler. It can be synchronous from
TestRunner's point of view. Layout test should not have to deal with this being
async.

> Tools/WebKitTestRunner/TestController.cpp:3388
> +    m_currentInvocation->didSetUseITPDatabase();

No need. This is called on a sync IPC from the WebContent process so once the
WKBundlePostSynchronousMessage() returns, the caller can assume the operation
has finished, given the runUntil() call above.