[webkit-reviews] review requested: [Bug 200384] Web Inspector: rework frontend agent construction to allow commands/events to be controlled by the related target's type : [Attachment 381088] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 16 11:16:23 PDT 2019


Devin Rousso <drousso at apple.com> has asked  for review:
Bug 200384: Web Inspector: rework frontend agent construction to allow
commands/events to be controlled by the related target's type
https://bugs.webkit.org/show_bug.cgi?id=200384

Attachment 381088: Patch

https://bugs.webkit.org/attachment.cgi?id=381088&action=review




--- Comment #39 from Devin Rousso <drousso at apple.com> ---
Created attachment 381088

  --> https://bugs.webkit.org/attachment.cgi?id=381088&action=review

Patch

Added some extra `console.assert` in potentially accident prone places, like
`hasCommand` being used instead of `hasDomain`.


More information about the webkit-reviews mailing list