[webkit-reviews] review granted: [Bug 203022] Fix the internal macOS build after r251171 : [Attachment 381052] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Wenson Hsieh <wenson_hsieh at apple.com>'s request for
review:
Bug 203022: Fix the internal macOS build after r251171
https://bugs.webkit.org/show_bug.cgi?id=203022

Attachment 381052: Patch

https://bugs.webkit.org/attachment.cgi?id=381052&action=review




--- Comment #3 from mitz at webkit.org ---
Comment on attachment 381052
  --> https://bugs.webkit.org/attachment.cgi?id=381052
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381052&action=review

> Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h:33
> +#pragma clang diagnostic ignored "-Wundef"

Is this still needed? The location ApplicationServicesPriv.h is being imported
from should be recognized as a system header location and therefore exempt from
warnings.

> Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h:59
> +extern AXClientType _AXGetClientForCurrentRequestUntrusted(void);

I know that this is just being moved around, but normally we keep function
declarations outside the #if/#else/#endif since it’s harmless to repeat a
declaration and it gives us extra protection in case the declaration in the
private header changes.