[webkit-reviews] review granted: [Bug 203014] [iOS] Maintain the last Back/Forward cache entry when the application gets suspended : [Attachment 381038] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 203014: [iOS] Maintain the last Back/Forward cache entry when the
application gets suspended
https://bugs.webkit.org/show_bug.cgi?id=203014

Attachment 381038: Patch

https://bugs.webkit.org/attachment.cgi?id=381038&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 381038
  --> https://bugs.webkit.org/attachment.cgi?id=381038
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381038&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:593
> +    if (m_prewarmedProcess)
> +	   m_prewarmedProcess->shutDown();

Do we need to kill the prewarmed process? Jetsam can always kill it if needed.
And it's a bummer to make the next link navigation slow in cases where you're
multitasking.

I guess this was our existing behavior, so my question may be out of scope of
this patch.

The same question applies to the process cache too.