[webkit-reviews] review granted: [Bug 202840] Web Inspector: Convert CSSRule selectorText setter to setSelectorText method because it's asynchronous : [Attachment 380907] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 202840: Web Inspector: Convert CSSRule selectorText setter to
setSelectorText method because it's asynchronous
https://bugs.webkit.org/show_bug.cgi?id=202840

Attachment 380907: Patch

https://bugs.webkit.org/attachment.cgi?id=380907&action=review




--- Comment #7 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 380907
  --> https://bugs.webkit.org/attachment.cgi?id=380907
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380907&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/CSSRule.js:114
> +    // This method is only needed to be called for CSS rules that don't
match the selected DOM node.

// This method only needs to be called

> Source/WebInspectorUI/UserInterface/Models/CSSRule.js:115
> +    // CSS rules that do match the selected DOM node get updated by
WI.DOMNodeStyles.prototype._parseRulePayload.

// CSS rules that match