[webkit-reviews] review granted: [Bug 203001] [macOS] Simplify main thread initialization : [Attachment 381012] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 203001: [macOS] Simplify main thread initialization
https://bugs.webkit.org/show_bug.cgi?id=203001

Attachment 381012: Patch

https://bugs.webkit.org/attachment.cgi?id=381012&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 381012
  --> https://bugs.webkit.org/attachment.cgi?id=381012
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381012&action=review

r=me

> Source/WTF/ChangeLog:10
> +

Probably worth mentioning that this change also enables the new white box
ASSERT that we don't initialize main thread to some other thread.

> Source/WebKitLegacy/mac/Misc/WebCache.mm:-68
>      JSC::initializeThreading();
> -    WTF::initializeMainThreadToProcessMainThread();

In cases like this, is it OK to call JSC::initializeThreading() and not
WTF::initializeMainThreadToProcessMainThread