[webkit-reviews] review granted: [Bug 202921] [GStreamer] Refactor track handling to use stream-ids in playbin3 mode : [Attachment 380876] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 202921: [GStreamer] Refactor track handling to use stream-ids in playbin3
mode
https://bugs.webkit.org/show_bug.cgi?id=202921

Attachment 380876: Patch

https://bugs.webkit.org/attachment.cgi?id=380876&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 380876
  --> https://bugs.webkit.org/attachment.cgi?id=380876
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380876&action=review

> Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:96
> +    else if (enabled) // playbin2: support for exactly one track of each
kind.
>	   m_player->enableTrack(TrackPrivateBaseGStreamer::TrackType::Audio,
m_index);

Not a strong opinion but for coherence with the pb3 function that asserts on
it, here I would do something like:

I'd do something like:
else {
    ASSERT(m_isLegacyPlaybin);
    if (enabled)
...

> Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:95
> +    else if (selected) // playbin2: support for exactly one track of each
kind.
> +	   m_player->enableTrack(TrackPrivateBaseGStreamer::TrackType::Audio,
m_index);

Ditto