[webkit-reviews] review granted: [Bug 202891] Pass CORS-enabled schemes through WebProcess instead of having them NetworkProcess-global : [Attachment 380935] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 202891: Pass CORS-enabled schemes through WebProcess instead of having them
NetworkProcess-global
https://bugs.webkit.org/show_bug.cgi?id=202891

Attachment 380935: Patch

https://bugs.webkit.org/attachment.cgi?id=380935&action=review




--- Comment #9 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 380935
  --> https://bugs.webkit.org/attachment.cgi?id=380935
Patch

LGTM other than the failing API test.

View in context: https://bugs.webkit.org/attachment.cgi?id=380935&action=review

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:533
> +    for (auto&& scheme : WTFMove(schemes))

No specific reason for WTFMove() here, or is it for documentation purposes?

> Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:52
> +NetworkLoadChecker::NetworkLoadChecker(NetworkProcess& networkProcess,
NetworkSchemeRegistry* schemeRegistry, FetchOptions&& options, PAL::SessionID
sessionID, WebPageProxyIdentifier webPageProxyID, HTTPHeaderMap&&
originalRequestHeaders, URL&& url, RefPtr<SecurityOrigin>&& sourceOrigin,
RefPtr<SecurityOrigin>&& topOrigin, PreflightPolicy preflightPolicy, String&&
referrer, bool isHTTPSUpgradeEnabled, bool
shouldCaptureExtraNetworkLoadMetrics, LoadType requestLoadType)

RefPtr<NetworkSchemeRegistry>&& with WTFMove
and I guess Ref<NetworkProces>>&& as well

> Source/WebKit/WebProcess/WebProcess.cpp:1182
> +	  
m_networkProcessConnection->connection().send(Messages::NetworkConnectionToWebP
rocess::RegisterURLSchemesAsCORSEnabled(WebCore::LegacySchemeRegistry::allURLSc
hemesRegisteredAsCORSEnabled()), 0);

We probably do not have tests for that.