[webkit-reviews] review granted: [Bug 202924] [GTK][WPE] WebKitWebContext should identify web views by their WebPageProxy identifier : [Attachment 380877] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 202924: [GTK][WPE] WebKitWebContext should identify web views by their
WebPageProxy identifier
https://bugs.webkit.org/show_bug.cgi?id=202924

Attachment 380877: Patch

https://bugs.webkit.org/attachment.cgi?id=380877&action=review




--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 380877
  --> https://bugs.webkit.org/attachment.cgi?id=380877
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380877&action=review

I just have a comment suggesting a small improvement to the code that
touches the “webViews” map, which could as well be a follow-up.

Otherwise r=me :)

> Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:1807
> +    context->priv->webViews.set(page.identifier().toUInt64(), webView);

Instead of having the explicit .toUInt64() conversions where the “webViews”
is used, the map could be declared as:

  HashMap<WebPageProxyIdentifier, WebKitWebView*> webViews;

This would make explicit in the data type that the mapping is from page
proxy identifiers to web views, and the compiler would help a little bit
doing type checks. There will be still a couple of (unavoidable) casts
when crossing the public API boundaries, but I think it would make the
code a bit more robust. Could be a follow-up patch :)