[webkit-reviews] review granted: [Bug 202929] [WK2] Have WebBackForwardCache class coordinate page caching in all WebProcesses : [Attachment 380951] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 202929: [WK2] Have WebBackForwardCache class coordinate page caching in all
WebProcesses
https://bugs.webkit.org/show_bug.cgi?id=202929

Attachment 380951: Patch

https://bugs.webkit.org/attachment.cgi?id=380951&action=review




--- Comment #10 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 380951
  --> https://bugs.webkit.org/attachment.cgi?id=380951
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380951&action=review

> Source/WebKit/UIProcess/WebBackForwardCache.h:70
> +    Vector<WebBackForwardListItem*> m_itemsWithCachedPage;

Might it be useful to have inline capacity of 2 here?

> Source/WebKit/UIProcess/WebProcessPool.h:598
>      WebProcessProxy* m_prewarmedProcess { nullptr };
>      WebProcessProxy* m_dummyProcessProxy { nullptr }; // A lightweight
WebProcessProxy without backing process.

These should probably be WeakPtr<WebProcessProxy>, maybe not in this patch.