[webkit-reviews] review granted: [Bug 202957] Web Inspector: Local Resource Overrides: automatically create an image/font local override when dragging content over a non-overridden resource : [Attachment 380937] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 202957: Web Inspector: Local Resource Overrides: automatically create an
image/font local override when dragging content over a non-overridden resource
https://bugs.webkit.org/show_bug.cgi?id=202957

Attachment 380937: Patch

https://bugs.webkit.org/attachment.cgi?id=380937&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 380937
  --> https://bugs.webkit.org/attachment.cgi?id=380937
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380937&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DropZoneView.js:75
> +    set text(text)

Might as well add a getter?

> Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:70
> +		  
this._importLocalResourceOverrideButtonNavigationItem.enabled = true;

I assume enabled is the default. Maybe this line can be removed.

> Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:77
>		  
this._removeLocalResourceOverrideButtonNavigationItem.enabled = true;

Probably this one too then.