[webkit-reviews] review granted: [Bug 202465] Python 3: Add support in webkitpy.common.net.bugzilla : [Attachment 380783] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 202465: Python 3: Add support in webkitpy.common.net.bugzilla
https://bugs.webkit.org/show_bug.cgi?id=202465

Attachment 380783: Patch

https://bugs.webkit.org/attachment.cgi?id=380783&action=review




--- Comment #5 from dewei_zhu at apple.com ---
Comment on attachment 380783
  --> https://bugs.webkit.org/attachment.cgi?id=380783
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380783&action=review

> Tools/Scripts/webkitpy/common/net/file_uploader.py:35
> +if sys.version_info > (3, 0):

Python has 3.0 release, do we want to use '>=' here instead?
Also, since we are repeating this a lot, maybe it's easier to make a helper
function?

> Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py:43
> +from webkitpy.thirdparty.BeautifulSoup import BeautifulSoup

Is there any specific reason to swap the import order? Or just make it follow
the case insensitive alphabetical order?

> Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py:30
> +	       # This hack isn't strictly accurate, but getting lxml to work
with the autoinstaller is a non-trivial task

Is this a FIXME then?

> Tools/Scripts/webkitpy/thirdparty/__init__.py:210
> +				"soupsieve-1.9.4/soupsieve")

Nit: this indentation doesn't match one style used in this file.

> Tools/Scripts/webkitpy/thirdparty/__init__.py:213
> +	       self._executive.run_command(['2to3', '-w',
self._fs.join(_AUTOINSTALLED_DIR, 'bs4')])

Ditto