[webkit-reviews] review granted: [Bug 202309] Handle service worker loads through NetworkResourceLoader : [Attachment 380863] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 202309: Handle service worker loads through NetworkResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=202309

Attachment 380863: Patch

https://bugs.webkit.org/attachment.cgi?id=380863&action=review




--- Comment #13 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 380863
  --> https://bugs.webkit.org/attachment.cgi?id=380863
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380863&action=review

>
Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:1
78
> +    Vector<ServiceWorkerFetchTask*> fetches;

Since we're no longer mutating m_ongoingFetches while iterating, could we
remove the use of the Vector?  If not, could we make this a safer pointer type?
 If not, could we at least use reserveInitialCapacity/uncheckedAppend?