[webkit-reviews] review granted: [Bug 202262] [Cocoa] REGRESSION (r245672): Contenteditable with optical sizing freezes Safari : [Attachment 380713] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 202262: [Cocoa] REGRESSION (r245672): Contenteditable with optical sizing
freezes Safari
https://bugs.webkit.org/show_bug.cgi?id=202262

Attachment 380713: Patch

https://bugs.webkit.org/attachment.cgi?id=380713&action=review




--- Comment #12 from Tim Horton <thorton at apple.com> ---
Comment on attachment 380713
  --> https://bugs.webkit.org/attachment.cgi?id=380713
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380713&action=review

> Source/WebKit/Shared/Cocoa/CoreTextHelpers.mm:2
> + * Copyright (C) 2017 Apple Inc. All rights reserved.

-2019?

> Source/WebKit/Shared/Cocoa/CoreTextHelpers.mm:52
> +    END_BLOCK_OBJC_EXCEPTIONS

I *think* this being post-return is OK, but I don't recall what it expands to