[webkit-reviews] review granted: [Bug 202876] requestIdleCallback cannot be enabled in DumpRenderTree on Windows : [Attachment 380814] Fixes DRT on Windows
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 11 21:31:19 PDT 2019
Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 202876: requestIdleCallback cannot be enabled in DumpRenderTree on Windows
https://bugs.webkit.org/show_bug.cgi?id=202876
Attachment 380814: Fixes DRT on Windows
https://bugs.webkit.org/attachment.cgi?id=380814&action=review
--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 380814
--> https://bugs.webkit.org/attachment.cgi?id=380814
Fixes DRT on Windows
View in context: https://bugs.webkit.org/attachment.cgi?id=380814&action=review
r=mews
> Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h:215
> +#define WebKitRequestIdleCallbackEnabledPreferenceKey
"RequestIdleCallbackEnabled"
Nit - it seems most of the other strings defined in this file are “WebKit*”.
Should this match that convention?
More information about the webkit-reviews
mailing list