[webkit-reviews] review granted: [Bug 201828] [macOS] Sandbox extensions should be created with audit tokens, not PIDs : [Attachment 380791] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 11 19:06:56 PDT 2019


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 201828: [macOS] Sandbox extensions should be created with audit tokens, not
PIDs
https://bugs.webkit.org/show_bug.cgi?id=201828

Attachment 380791: Patch

https://bugs.webkit.org/attachment.cgi?id=380791&action=review




--- Comment #16 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 380791
  --> https://bugs.webkit.org/attachment.cgi?id=380791
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380791&action=review

Looks good,

> Source/WTF/wtf/spi/darwin/SandboxSPI.h:-61
> -extern const uint32_t SANDBOX_EXTENSION_USER_INTENT;

Was this never used? Good to remove.


More information about the webkit-reviews mailing list