[webkit-reviews] review granted: [Bug 202716] Make WebInspector's remote debug EventLoop code into RunLoop : [Attachment 380716] Updated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 11 13:34:47 PDT 2019


Joseph Pecoraro <joepeck at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 202716: Make WebInspector's remote debug EventLoop code into RunLoop
https://bugs.webkit.org/show_bug.cgi?id=202716

Attachment 380716: Updated

https://bugs.webkit.org/attachment.cgi?id=380716&action=review




--- Comment #11 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 380716
  --> https://bugs.webkit.org/attachment.cgi?id=380716
Updated

View in context: https://bugs.webkit.org/attachment.cgi?id=380716&action=review

r=me

> Source/WTF/wtf/RunLoop.h:65
> +    WTF_EXPORT_PRIVATE CycleResult static cycle(String = { });

Can this be a `const String&` or does it need to be a `String` for a particular
reason?


More information about the webkit-reviews mailing list