[webkit-reviews] review granted: [Bug 202853] Remove some dead code in webkitpy's mac.py : [Attachment 380764] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 11 12:36:33 PDT 2019


Alexey Proskuryakov <ap at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 202853: Remove some dead code in webkitpy's mac.py
https://bugs.webkit.org/show_bug.cgi?id=202853

Attachment 380764: Patch

https://bugs.webkit.org/attachment.cgi?id=380764&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 380764
  --> https://bugs.webkit.org/attachment.cgi?id=380764
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380764&action=review

> Tools/Scripts/webkitpy/port/mac.py:-272
> -	   # FIXME: Remove this after <rdar://problem/15605007> is fixed.
> -	   logging_patterns.append((re.compile('(AVF|GVA) info:.*\n'), ''))

Seeing other instances of similar logging from same sources below, I wonder if
we should treat stripping that as a permanent feature.


More information about the webkit-reviews mailing list