[webkit-reviews] review granted: [Bug 202833] GenerateAndAllocateRegisters can trivially elide self moves at end of liveness : [Attachment 380708] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 202833: GenerateAndAllocateRegisters can trivially elide self moves at end
of liveness
https://bugs.webkit.org/show_bug.cgi?id=202833

Attachment 380708: Patch

https://bugs.webkit.org/attachment.cgi?id=380708&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 380708
  --> https://bugs.webkit.org/attachment.cgi?id=380708
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380708&action=review

>
Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:54
> +	   if (!reg)
> +	       return;

should we assert here that nothing in m_currentAllocation points to tmp?