[webkit-reviews] review denied: [Bug 200262] Web Inspector: support emulateUserGesture parameter in Runtime.callFunctionOn : [Attachment 375165] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 10 14:28:20 PDT 2019


Joseph Pecoraro <joepeck at webkit.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 200262: Web Inspector: support emulateUserGesture parameter in
Runtime.callFunctionOn
https://bugs.webkit.org/show_bug.cgi?id=200262

Attachment 375165: Patch

https://bugs.webkit.org/attachment.cgi?id=375165&action=review




--- Comment #14 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 375165
  --> https://bugs.webkit.org/attachment.cgi?id=375165
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375165&action=review

>>
LayoutTests/inspector/runtime/callFunctionOn-userGestureEmulation-userIsInterac
ting.html:12
>> +	    TestPage.addResult(window.internals.userIsInteracting() ? "User is
Interacting" : "User is NOT Interacting");
> 
> Can you also make another test that checks
`window.internals.isProcessingUserGesture()`?
> As an example, you can look at
<inspector/runtime/evaluate-userGestureEmulation.html>.

I think this is the only reason this has been in limbo. r- for this additional
test.


More information about the webkit-reviews mailing list