[webkit-reviews] review granted: [Bug 202660] Move SuspendedPage logic from WebProcessPool to new WebBackForwardCache class : [Attachment 380465] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 202660: Move SuspendedPage logic from WebProcessPool to new
WebBackForwardCache class
https://bugs.webkit.org/show_bug.cgi?id=202660

Attachment 380465: Patch

https://bugs.webkit.org/attachment.cgi?id=380465&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 380465
  --> https://bugs.webkit.org/attachment.cgi?id=380465
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380465&action=review

> Source/WebKit/UIProcess/SuspendedPageProxy.cpp:147
> +void SuspendedPageProxy::setBackForwardListItem(WebBackForwardListItem*
item)
> +{
> +    ASSERT(!m_backForwardListItem || !item);

Considering the assert it would be better to divide this into separate
set/clear functions (where set takes a reference).

> Source/WebKit/UIProcess/SuspendedPageProxy.cpp:149
> +    if (m_backForwardListItem)
> +	  
process().processPool().backForwardCache().unregisterItemWithCachedPage(*m_back
ForwardListItem);

The only call sites for setBackForwardListItem are in WebBackForwardListItem.
Is it odd that registering WebBackForwardListItems is managed here instead of
the call sites?