[webkit-reviews] review denied: [Bug 202626] Move font-rendering code from CanvasRenderingContext2D to CanvasRenderingContext2DBase to be used with OffscreenCanvas : [Attachment 380631] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Chris Lord <clord at igalia.com>'s
request for review:
Bug 202626: Move font-rendering code from CanvasRenderingContext2D to
CanvasRenderingContext2DBase to be used with OffscreenCanvas
https://bugs.webkit.org/show_bug.cgi?id=202626

Attachment 380631: Patch

https://bugs.webkit.org/attachment.cgi?id=380631&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 380631
  --> https://bugs.webkit.org/attachment.cgi?id=380631
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380631&action=review

> Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.cpp:60
> +    auto parsedStyle = MutableStyleProperties::create();
> +    CSSParser::parseValue(parsedStyle, CSSPropertyFont, newFont, true,
strictToCSSParserMode(!m_usesCSSCompatibilityParseMode));
> +    if (parsedStyle->isEmpty())

As far as I know, CSS parser isn't thread safe due to CSSValuePool and other
static variables.
For example, consumeFontWeightKeywordValue would use
CSSValuePool::singleton().createIdentifierValue.