[webkit-reviews] review granted: [Bug 202787] Do not timeout a load intercepted by service worker that receives a response : [Attachment 380628] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 202787: Do not timeout a load intercepted by service worker that receives a
response
https://bugs.webkit.org/show_bug.cgi?id=202787

Attachment 380628: Patch

https://bugs.webkit.org/attachment.cgi?id=380628&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 380628
  --> https://bugs.webkit.org/attachment.cgi?id=380628
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380628&action=review

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:94
>      m_timeoutTimer.stop();

Do we need this? Can didFinish() be called without didReceiveResponse() getting
called first? Maybe this could be an assertion?