[webkit-reviews] review granted: [Bug 195422] Get StorageAccess API features working on SQLite database implementation : [Attachment 380595] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Katherine_cheney at apple.com's
request for review:
Bug 195422: Get StorageAccess API features working on SQLite database
implementation
https://bugs.webkit.org/show_bug.cgi?id=195422

Attachment 380595: Patch

https://bugs.webkit.org/attachment.cgi?id=380595&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 380595
  --> https://bugs.webkit.org/attachment.cgi?id=380595
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380595&action=review

Thanks for checking and fixing these.

> Source/WebKit/ChangeLog:10
> +	   use the ITP database and uncovered 3 bugs in the process.

Hooray for tests!

>
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
:1164
> +    if (cookieTreatmentResult != CookieTreatmentResult::BlockAndKeep) {

Good. This now matches the behavior in the memory store after we finalized the
StorageAccess API behavior.

>
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
:1722
> +    return !!statement.getColumnInt(0) ? StorageAccessPromptWasShown::Yes :
StorageAccessPromptWasShown::No;

Oh, whoops! Nice catch.

> LayoutTests/ChangeLog:21
> +	   *
http/tests/storageAccess/deny-storage-access-under-opener-database-expected.txt
: Added.

Using 'svn copy' used to show that these files were just copies of originals,
then show a small patch of the change. Did you use git to generate these
patches?