[webkit-reviews] review granted: [Bug 202763] [WinCairo] Move remote communication handling from RemoteInspectorServer to RemoteInspector. : [Attachment 380575] PATCH

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 202763: [WinCairo] Move remote communication handling from
RemoteInspectorServer to RemoteInspector.
https://bugs.webkit.org/show_bug.cgi?id=202763

Attachment 380575: PATCH

https://bugs.webkit.org/attachment.cgi?id=380575&action=review




--- Comment #3 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 380575
  --> https://bugs.webkit.org/attachment.cgi?id=380575
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=380575&action=review

> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.cpp:32
> +

Nit: You don't need a newline here (since it's RemoteInspectorMessageParser.h,
not RemoteInspectorServer.h).

> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.h:49
> +    void didClose(ConnectionID) override { };

Nit: No semicolon needed.

>
Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp
:106
> +#if PLATFORM(PLAYSTATION) || PLATFORM(WIN)

Maybe this should be USE(GENERIC_EVENT_LOOP) || USE(WINDOWS_EVENT_LOOP) ?