[webkit-reviews] review granted: [Bug 202769] Web Inspector: Modifying CSS selectors causes 2 CSS.setRuleSelector backend calls : [Attachment 380583] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 202769: Web Inspector: Modifying CSS selectors causes 2 CSS.setRuleSelector
backend calls
https://bugs.webkit.org/show_bug.cgi?id=202769

Attachment 380583: Patch

https://bugs.webkit.org/attachment.cgi?id=380583&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 380583
  --> https://bugs.webkit.org/attachment.cgi?id=380583
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380583&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetSelectorField.js:115
> +	       this._delegate.spreadsheetSelectorFieldDidCommit(changed);

Should we just skip calling `this._delegate.spreadsheetSelectorFieldDidCommit`
altogether if !changed, instead of passing it as an argument?