[webkit-reviews] review granted: [Bug 202753] [Cocoa] IPC::decode should gracefully handle a nil allowed class : [Attachment 380537] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 9 10:01:14 PDT 2019


Geoffrey Garen <ggaren at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 202753: [Cocoa] IPC::decode should gracefully handle a nil allowed class
https://bugs.webkit.org/show_bug.cgi?id=202753

Attachment 380537: Patch

https://bugs.webkit.org/attachment.cgi?id=380537&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 380537
  --> https://bugs.webkit.org/attachment.cgi?id=380537
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380537&action=review

r=me

> Source/WebKit/ChangeLog:20
> +	   rdar://problem/55839467 was resolved by fixing the build
misconfiguration, but this patch
> +	   improves IPC::decode so that a nil allowed class results in a
message decoding failure
> +	   rather than a maybe-caught NSException.
> +

What do message decoding failures do at runtime? Would this error we
experienced still be obvious, or would it become more subtle?


More information about the webkit-reviews mailing list