[webkit-reviews] review granted: [Bug 202707] IsLoggedIn: Add as experimental feature : [Attachment 380499] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 202707: IsLoggedIn: Add as experimental feature
https://bugs.webkit.org/show_bug.cgi?id=202707

Attachment 380499: Patch

https://bugs.webkit.org/attachment.cgi?id=380499&action=review




--- Comment #9 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 380499
  --> https://bugs.webkit.org/attachment.cgi?id=380499
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380499&action=review

I don't think the api-mac failure is related to this patch, but please
double-check.

It also looks like the patch does not apply cleanly to the tree.

Otherwise, this seems fine though I would suggest removing the 'm_navigator'
member of the class, since it is not used anywhere.

> Source/WebCore/page/NavigatorIsLoggedIn.h:55
> +    Navigator& m_navigator;

I don't think you need to hold this reference to Navigator, since the entire
API expects to receive the Navigator as an argument.

> LayoutTests/ChangeLog:40
> +	   * http/tests/is-logged-in/unavailable-in-insecure-contexts.html:
Added.

Whoops! Double changelog!