[webkit-reviews] review granted: [Bug 202735] MediaTime pretty printer can print if time is invalid : [Attachment 380522] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 202735: MediaTime pretty printer can print if time is invalid
https://bugs.webkit.org/show_bug.cgi?id=202735

Attachment 380522: Patch

https://bugs.webkit.org/attachment.cgi?id=380522&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 380522
  --> https://bugs.webkit.org/attachment.cgi?id=380522
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380522&action=review

> Source/WTF/wtf/MediaTime.cpp:598
> +    if (isInvalid())
> +	   builder.appendLiteral(", invalid");

It would be nice to fix MediaTime::toJSONObject as well. Something like:

if (isInvalid())
    object->setBoolean("invalid"_s, true);