[webkit-reviews] review granted: [Bug 202719] [CSS Shadow Parts] Allow exporting single part with multiple names using exportparts attribute : [Attachment 380502] patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 202719: [CSS Shadow Parts] Allow exporting single part with multiple names
using exportparts attribute
https://bugs.webkit.org/show_bug.cgi?id=202719

Attachment 380502: patch

https://bugs.webkit.org/attachment.cgi?id=380502&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 380502
  --> https://bugs.webkit.org/attachment.cgi?id=380502
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380502&action=review

> Source/WebCore/css/SelectorChecker.cpp:1181
> +	       for (unsigned i = 0; i < element.partNames().size(); ++i)

We can’t use range loop?

> Source/WebCore/dom/ShadowRoot.h:99
> +    using PartMappings = HashMap<AtomString, Vector<AtomString, 1>>;

Should we typedef Vector?