[webkit-reviews] review granted: [Bug 202031] Web Inspector: Canvas: modifications to shader modules can be shared between vertex/fragment shaders : [Attachment 380452] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 202031: Web Inspector: Canvas: modifications to shader modules can be
shared between vertex/fragment shaders
https://bugs.webkit.org/show_bug.cgi?id=202031

Attachment 380452: Patch

https://bugs.webkit.org/attachment.cgi?id=380452&action=review




--- Comment #10 from Dean Jackson <dino at apple.com> ---
Comment on attachment 380452
  --> https://bugs.webkit.org/attachment.cgi?id=380452
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380452&action=review

> Source/WebCore/inspector/InspectorShaderProgram.cpp:283
> +    auto payload = Inspector::Protocol::Canvas::ShaderProgram::create()
> +	   .setProgramId(m_identifier)
> +	   .setProgramType(programType.value())
> +	   .setCanvasId(m_canvas.identifier())
> +	   .release();

Did you swap to Java here? :)