[webkit-reviews] review requested: [Bug 202656] [JSC] GetterSetter should be JSCell, not JSObject : [Attachment 380461] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 8 14:12:53 PDT 2019
Saam Barati <sbarati at apple.com> has asked for review:
Bug 202656: [JSC] GetterSetter should be JSCell, not JSObject
https://bugs.webkit.org/show_bug.cgi?id=202656
Attachment 380461: Patch
https://bugs.webkit.org/attachment.cgi?id=380461&action=review
--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 380461
--> https://bugs.webkit.org/attachment.cgi?id=380461
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=380461&action=review
> Source/JavaScriptCore/ChangeLog:13
> + 2. RHS of that comparison is always folded into constant in DFG.
do we do the right thing even when RHS isn't folded?
> Source/JavaScriptCore/ChangeLog:17
> + So we already support non-JSString/JSBigInt cell comparison in JSC
JS code. We should use it instead of making GetterSetter JSObject.
this support was added after we made GetterSetter a JSObject?
More information about the webkit-reviews
mailing list