[webkit-reviews] review granted: [Bug 202662] Copying white text from dark mode WebKit apps and pasting in a light mode app results in white (invisible) text : [Attachment 380438] Patch

[bugzilla-daemon at webkit.org]

Megan Gardner <megan_gardner at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 202662: Copying white text from dark mode WebKit apps and pasting in a
light mode app results in white (invisible) text
https://bugs.webkit.org/show_bug.cgi?id=202662

Attachment 380438: Patch

https://bugs.webkit.org/attachment.cgi?id=380438&action=review




--- Comment #5 from Megan Gardner <megan_gardner at apple.com> ---
Comment on attachment 380438
  --> https://bugs.webkit.org/attachment.cgi?id=380438
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380438&action=review

> Source/WebCore/editing/cocoa/HTMLConverter.mm:-864
> -    if (red < ColorEpsilon && green < ColorEpsilon && blue < ColorEpsilon &&
(ignoreBlack || alpha < ColorEpsilon))

I'm guessing this was basically looking for 'black'. I don't know what the
trade off for looking for 'probably almost black' and 'true black' is, but I'm
trusting this is equal or better than Color::isBlackColor.

> Source/WebCore/editing/cocoa/HTMLConverter.mm:882
> +

nit whitespace?