[webkit-reviews] review granted: [Bug 202679] Web Inspector: Canvas: don't show an empty preview for WebGPU devices : [Attachment 380393] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 202679: Web Inspector: Canvas: don't show an empty preview for WebGPU
devices
https://bugs.webkit.org/show_bug.cgi?id=202679

Attachment 380393: Patch

https://bugs.webkit.org/attachment.cgi?id=380393&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 380393
  --> https://bugs.webkit.org/attachment.cgi?id=380393
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380393&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/Canvas.js:127
> +	   return true;

I know this was written with future contextTypes in mind, but I'd just replace
it with:

return contextType !== Canvas.ContextType.WebGPU && contextType !==
Canvas.ContextType.WebMetal;