[webkit-reviews] review granted: [Bug 202697] [LFC][Painting] Add very basic block and inline painting : [Attachment 380437] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 8 09:39:18 PDT 2019


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 202697: [LFC][Painting] Add very basic block and inline painting
https://bugs.webkit.org/show_bug.cgi?id=202697

Attachment 380437: Patch

https://bugs.webkit.org/attachment.cgi?id=380437&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 380437
  --> https://bugs.webkit.org/attachment.cgi?id=380437
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380437&action=review

> Source/WebCore/layout/displaytree/DisplayPainter.cpp:99
> +static void paintInlineContent(GraphicsContext& context, const Box&
absoluteDisplayBox, const RenderStyle& style, const String& content, const
Layout::InlineFormattingState& formattingState)

Maybe things like GraphicsContext should become members of the Painter?


More information about the webkit-reviews mailing list