[webkit-reviews] review granted: [Bug 175764] Fetch: data: URL HEAD request should result in empty response body : [Attachment 380410] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 175764: Fetch: data: URL HEAD request should result in empty response body
https://bugs.webkit.org/show_bug.cgi?id=175764

Attachment 380410: Patch

https://bugs.webkit.org/attachment.cgi?id=380410&action=review




--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 380410
  --> https://bugs.webkit.org/attachment.cgi?id=380410
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380410&action=review

> Source/WebCore/loader/ResourceLoader.cpp:288
> +	       if (!this->reachedTerminalState() && dataSize &&
m_request.httpMethod() != "HEAD")

I believe we correctly handle these cases but do we have test coverage for gEt
or HeAD?

As a side-note, we probably currently fail HEAD requests for blobs.
Are we expected to also do the same as for data URLs?

Since no HEAD request is expected to give a response with a body, I guess we
could add an ASSERT in DocumentThreadableLoader to ensure that.