[webkit-reviews] review granted: [Bug 202645] [GTK] Navigation gesture improvements : [Attachment 380340] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 8 00:46:29 PDT 2019


Carlos Garcia Campos <cgarcia at igalia.com> has granted Alexander Mikhaylenko
<alexm at gnome.org>'s request for review:
Bug 202645: [GTK] Navigation gesture improvements
https://bugs.webkit.org/show_bug.cgi?id=202645

Attachment 380340: Patch

https://bugs.webkit.org/attachment.cgi?id=380340&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 380340
  --> https://bugs.webkit.org/attachment.cgi?id=380340
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380340&action=review

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:184
> +	   deltaX *= (double) Scrollbar::pixelsPerLineStep() / m_distance;

I know this is na existing issue, but please use C++ style cast.


More information about the webkit-reviews mailing list