[webkit-reviews] review granted: [Bug 201957] IndexedDB: update size to actual disk usage only when estimated increase is bigger than space available : [Attachment 380385] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 201957: IndexedDB: update size to actual disk usage only when estimated
increase is bigger than space available
https://bugs.webkit.org/show_bug.cgi?id=201957

Attachment 380385: Patch

https://bugs.webkit.org/attachment.cgi?id=380385&action=review




--- Comment #41 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 380385
  --> https://bugs.webkit.org/attachment.cgi?id=380385
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380385&action=review

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:225
> +    m_pendingSpaceIncreaseTasks.add(identifier, taskSize);

Add ASSERT(!m_pendingSpaceIncreaseTasks.add(identifier))

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:230
> +    auto iterator = m_pendingSpaceIncreaseTasks.find(identifier);

Can we add an ASSERT, something like ASSERT(iterator !=
m_pendingSpaceIncreaseTasks.end() || !isTaskSuccessful);

> Source/WebCore/storage/StorageQuotaManager.h:96
> +    State m_state { State::Uninitialized };

We might want to add some API tests for StorageQuotaManager like we are doing
for other utility classes like Strings.