[webkit-reviews] review granted: [Bug 202483] IndexedDB: include size of index records in size estimate of put/add task : [Attachment 380330] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 202483: IndexedDB: include size of index records in size estimate of
put/add task
https://bugs.webkit.org/show_bug.cgi?id=202483

Attachment 380330: Patch

https://bugs.webkit.org/attachment.cgi?id=380330&action=review




--- Comment #13 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 380330
  --> https://bugs.webkit.org/attachment.cgi?id=380330
Patch

r=me

Unless the result is impractical, I think we should land this change with a
test case similar to the one you uploaded, with indexCount set to 1000000,
and/or createObject() set to call randomArray(1000000)). That way, the test
documents the reason we made this implementation choice, and it can be used to
qualified other implementations we may want to try out in the future.