[webkit-reviews] review granted: [Bug 202569] [JSC] Change signature of HostFunction to (JSGlobalObject*, CallFrame*) : [Attachment 380260] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 202569: [JSC] Change signature of HostFunction to (JSGlobalObject*,
CallFrame*)
https://bugs.webkit.org/show_bug.cgi?id=202569

Attachment 380260: Patch

https://bugs.webkit.org/attachment.cgi?id=380260&action=review




--- Comment #10 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 380260
  --> https://bugs.webkit.org/attachment.cgi?id=380260
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380260&action=review

r=me

>> Source/JavaScriptCore/jit/ThunkGenerators.cpp:273
>>	// Calling convention:	    f(edi, esi, edx, ecx, ...);
> 
> ThunkGenerators.cpp change is important.

can we file a bug on using GPRInfo here instead of naming registers?

> Source/JavaScriptCore/jit/ThunkGenerators.cpp:337
> +    static_assert(GPRInfo::regT2 != GPRInfo::argumentGPR0);
> +    static_assert(GPRInfo::regT2 != GPRInfo::argumentGPR1);

I think arm64 and x86_64 on Windows/*nix can easily be written using GPRInfo
and RegisterSet. As I said above, filing a bug for this work would be nice (you
don't necessarily need to do the work, but we should just have a bug)