[webkit-reviews] review granted: [Bug 202063] Tool to mark jsc test skip/enable : [Attachment 379284] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Zhifei Fang
<zhifei_fang at apple.com>'s request for review:
Bug 202063: Tool to mark jsc test skip/enable
https://bugs.webkit.org/show_bug.cgi?id=202063

Attachment 379284: Patch

https://bugs.webkit.org/attachment.cgi?id=379284&action=review




--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 379284
  --> https://bugs.webkit.org/attachment.cgi?id=379284
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379284&action=review

r=me with option name change.

> Tools/Scripts/mark-jsc-stress-test:127
> +    if args["jsc_json_output"]:

Does python convert the - to _? That's bizarre...

>> Tools/Scripts/run-jsc-stress-tests:187
>> +		   ['--hardware', GetoptLong::REQUIRED_ARGUMENT],
> 
> Is it ok that this is a required argument, but it’s only added conditionally
by the caller?
> 
> Also, while I don’t have a better suggestion, the argument name feels unusual
to me. Is there any precedent for —hardware? Please respond privately if it’s
internal.

Yeah, hardware is a bit of a weird name in the context of JSC tests since JSC
cares about both the platform and the architecture. Can we call this platform
instead?