[webkit-reviews] review granted: [Bug 202338] Switch to WKShareSheet for WKPDFView : [Attachment 380342] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 202338: Switch to WKShareSheet for WKPDFView
https://bugs.webkit.org/show_bug.cgi?id=202338

Attachment 380342: Patch

https://bugs.webkit.org/attachment.cgi?id=380342&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 380342
  --> https://bugs.webkit.org/attachment.cgi?id=380342
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380342&action=review

> Source/WebKit/ChangeLog:10
> +	   us to eliminate this mostly unused class.

Now entirely unused?

> Source/WebKit/UIProcess/ios/WKPDFView.h:32
> + at interface WKPDFView : WKApplicationStateTrackingView
<WKWebViewContentProvider, WKShareSheetDelegate>

Keep these sorted :P

> Source/WebKit/UIProcess/ios/WKPDFView.mm:564
> +    [_shareSheet presentWithParameters:shareData inRect: {
[[_hostViewController view] convertRect:boundingRect toView:webView] }
completionHandler:[] (bool success) { }];

Is there not a way to pass a null completion handler? Maybe not.