[webkit-reviews] review granted: [Bug 202649] Web Inspector: inspector/layers/layers-for-node.html and inspector/timeline/line-column.html are flaky : [Attachment 380350] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 202649: Web Inspector: inspector/layers/layers-for-node.html and 
inspector/timeline/line-column.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=202649

Attachment 380350: Patch

https://bugs.webkit.org/attachment.cgi?id=380350&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 380350
  --> https://bugs.webkit.org/attachment.cgi?id=380350
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380350&action=review

rs=me

> LayoutTests/inspector/layers/layers-for-node.html:25
> +	   layersChanged = InspectorProtocol.awaitEvent({event:
"LayerTree.layerTreeDidChange"})

Frankly, given that `enableLayerTreeAgent` is called synchronously at the start
of the test, perhaps we should just inline this at the top of `test` as a sort
of "make sure we get at least one of these before continuing with the rest of
the test".

> LayoutTests/inspector/layers/layers-for-node.html:36
> +	   layersChanged.then(() => step({

Style: if the body of the arrow function is more than one line (or the value
isn't intended as the return value), we add the `{ ... }` to the arrow
function.
```js
    layersChanged.then(() => {
	step({
	    ...
	});
    });
```