[webkit-reviews] review granted: [Bug 202639] results.webkit.org: Start reporting results : [Attachment 380335] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 7 12:04:29 PDT 2019


dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 202639: results.webkit.org: Start reporting results
https://bugs.webkit.org/show_bug.cgi?id=202639

Attachment 380335: Patch

https://bugs.webkit.org/attachment.cgi?id=380335&action=review




--- Comment #2 from dewei_zhu at apple.com ---
Comment on attachment 380335
  --> https://bugs.webkit.org/attachment.cgi?id=380335
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380335&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py:52
> +    results_server_api_key = passwords.get('RESULTS_SERVER_API_KEY')

We usually use lower case for config json keys?


More information about the webkit-reviews mailing list