[webkit-reviews] review granted: [Bug 202590] DOMCache should not prevent pages from entering the back/forward cache : [Attachment 380329] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 202590: DOMCache should not prevent pages from entering the back/forward
cache
https://bugs.webkit.org/show_bug.cgi?id=202590

Attachment 380329: Patch

https://bugs.webkit.org/attachment.cgi?id=380329&action=review




--- Comment #9 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 380329
  --> https://bugs.webkit.org/attachment.cgi?id=380329
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380329&action=review

> Source/WebCore/Modules/cache/DOMCache.cpp:450
> +    queryCache(request.releaseNonNull(), WTFMove(options), [this,
protectedThis = makeRef(*this), promise =
WTFMove(promise)](ExceptionOr<Vector<CacheStorageRecord>>&& result) mutable {

auto&& here and above as well if we want.

> Source/WebCore/Modules/cache/DOMCache.h:61
> +    using MatchCallback =
WTF::Function<void(ExceptionOr<RefPtr<FetchResponse>>)>;

s/WTF:://

> Source/WebCore/Modules/cache/DOMCacheStorage.cpp:63
> +    cache.doMatch(WTFMove(info), WTFMove(options), [caches =
WTFMove(caches), info, options, completionHandler = WTFMove(completionHandler),
index](ExceptionOr<RefPtr<FetchResponse>>&& result) mutable {

auto&&

> Source/WebCore/Modules/cache/DOMCacheStorage.cpp:88
> +    startSequentialMatch(WTF::map(m_caches, copyCache), WTFMove(info),
WTFMove(options), [this, pendingActivity = makePendingActivity(*this), promise
= WTFMove(promise)](ExceptionOr<RefPtr<FetchResponse>>&& result) mutable {

auto&&