[webkit-reviews] review denied: [Bug 202500] Only wrapping CryptoKeys for IDB during serialization : [Attachment 380305] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Jiewen Tan <jiewen_tan at apple.com>'s
request for review:
Bug 202500: Only wrapping CryptoKeys for IDB during serialization
https://bugs.webkit.org/show_bug.cgi?id=202500

Attachment 380305: Patch

https://bugs.webkit.org/attachment.cgi?id=380305&action=review




--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 380305
  --> https://bugs.webkit.org/attachment.cgi?id=380305
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380305&action=review

r- due to failures.

> Source/WebCore/workers/WorkerGlobalScope.cpp:418
> +    m_thread.workerLoaderProxy().postTaskToLoader([resultContainer =
resultContainer.copyRef(), key, wrappedKeyContainer =
wrappedKeyContainer.copyRef(), doneContainer = doneContainer.copyRef(),
workerMessagingProxy =
Ref<WorkerMessagingProxy>(downcast<WorkerMessagingProxy>(m_thread.workerLoaderP
roxy()))](ScriptExecutionContext& context) {

Why not use makeRef() instead of Ref<WorkerMessagingProxy>() ?

> Source/WebCore/workers/WorkerGlobalScope.cpp:421
> +	  
static_cast<WorkerLoaderProxy&>(workerMessagingProxy.get()).postTaskForModeToWo
rkerGlobalScope([](ScriptExecutionContext& context) {

Why is the static_cast() needed?