[webkit-reviews] review granted: [Bug 202432] focus pseudo class should match a shadow host whose shadow tree contains the focused element : [Attachment 380278] Reverted unintended test change

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 202432: focus pseudo class should match a shadow host whose shadow tree
contains the focused element
https://bugs.webkit.org/show_bug.cgi?id=202432

Attachment 380278: Reverted unintended test change

https://bugs.webkit.org/attachment.cgi?id=380278&action=review




--- Comment #8 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 380278
  --> https://bugs.webkit.org/attachment.cgi?id=380278
Reverted unintended test change

View in context: https://bugs.webkit.org/attachment.cgi?id=380278&action=review

> Source/WebCore/css/CSSSelector.cpp:443
> +	       case CSSSelector::PseudoClassDirectFocus:
> +		   str.appendLiteral(":-webkit-direct-focus");
> +		   break;

I suppose some code generator strips 'webkit' out from the enum values? I
wonder if we could avoid that for internal properties (have
PseudoClassWebKitDirectFocus)

> Source/WebCore/css/html.css:1168
> -:focus {
> +:-webkit-direct-focus {

Do other instances of :focus on UA sheets also need to be changed to
:-webkit-direct-focus? html4.css has more, and svg.css and mathml.css also have
instances.

> Source/WebCore/css/parser/CSSSelectorParser.cpp:501
> +	       if (m_context.mode != UASheetMode && selector->pseudoClassType()
== CSSSelector::PseudoClassDirectFocus)
> +		   return nullptr;

We should have some sort of more general mechanism for hiding internal pseudo
classes. (like hide based on the name)