[webkit-reviews] review granted: [Bug 202370] Allow pages using EventSource to enter the back/forward cache : [Attachment 379950] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 202370: Allow pages using EventSource to enter the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=202370

Attachment 379950: Patch

https://bugs.webkit.org/attachment.cgi?id=379950&action=review




--- Comment #9 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 379950
  --> https://bugs.webkit.org/attachment.cgi?id=379950
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379950&action=review

r=me

> Source/WebCore/page/EventSource.cpp:427
> +    if (std::exchange(m_shouldDispatchErrorEventOnResume, false)) {
> +	   scriptExecutionContext()->postTask([this, pendingActivity =
makePendingActivity(*this)](ScriptExecutionContext&) {
> +	       if (!isContextStopped())
> +		   dispatchErrorEvent();
> +	   });

Would it be crazy just to silently reconnect instead?