[webkit-reviews] review granted: [Bug 202553] Move WKProcessPool._registerURLSchemeServiceWorkersCanHandle to _WKWebsiteDataStoreConfiguration : [Attachment 380175] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 202553: Move WKProcessPool._registerURLSchemeServiceWorkersCanHandle to
_WKWebsiteDataStoreConfiguration
https://bugs.webkit.org/show_bug.cgi?id=202553

Attachment 380175: Patch

https://bugs.webkit.org/attachment.cgi?id=380175&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 380175
  --> https://bugs.webkit.org/attachment.cgi?id=380175
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380175&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2429
> +void NetworkProcess::addServiceWorkerSession(PAL::SessionID sessionID, bool
processTerminationDelayEnabled, HashSet<String>&& registeredSchemes, String&
serviceWorkerRegistrationDirectory, const SandboxExtension::Handle& handle)

Seems strange to have a String& serviceWorkerRegistrationDirectory.
I guess this would be a String&& ideally.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:489
> +    [dataStore removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes]
modifiedSince:[NSDate distantPast] completionHandler:^() {

It might be good to leave a test using the default data store.